Skip to content

Use same JVM that maven is using.#43

Merged
katrinsharp merged 4 commits into
scalatest:masterfrom
cstroe:use-correct-java
Aug 8, 2019
Merged

Use same JVM that maven is using.#43
katrinsharp merged 4 commits into
scalatest:masterfrom
cstroe:use-correct-java

Conversation

@cstroe

@cstroe cstroe commented May 25, 2017

Copy link
Copy Markdown
Contributor

Use the java executable that Maven ran with. Inspired from the Surefire plugin's getEffectiveJvm minus the toolchain lookup.

Fixes #6, #14 and #26

@cstroe

cstroe commented May 25, 2017

Copy link
Copy Markdown
Contributor Author

@gcberger I'd love to have this be included in the upcoming version 2.0.0!

@cstroe

cstroe commented Jun 1, 2017

Copy link
Copy Markdown
Contributor Author

@gcberger Any chance in merging this?

@robsonpeixoto

Copy link
Copy Markdown

@gcberger ping

@andrewdibiasio6

Copy link
Copy Markdown

I echo this @gcberger "Any chance in merging this?"

@gcberger

gcberger commented Oct 4, 2017 via email

Copy link
Copy Markdown
Contributor

@Mats-SX

Mats-SX commented Nov 5, 2018

Copy link
Copy Markdown

Ping. We'd love to have this.

@martin-g

Copy link
Copy Markdown

I think a better solution would be to make scalatest-maven-plugin toolchains aware (#58). I don't think this PR would solve the issue described at #58 .

@cstroe

cstroe commented Nov 16, 2018

Copy link
Copy Markdown
Contributor Author

I think the delay is that I have to sign the CLA, which has to be approved by my current employer: #37 (comment)

Also, yes, we should definitely make this plugin Toolchain aware, but that could be subsequent work.

@martin-g

Copy link
Copy Markdown

I can do the work to use ToolchainManager in the coming days if there is a chance that it will be ever used. This PR is one year and a half old and it seems there is no much interest from the maintainers.

@cstroe

cstroe commented Nov 16, 2018

Copy link
Copy Markdown
Contributor Author

Some options to solve maintainership absence:

  1. The current maintainers can add an active member of the OSS community as a committer/maintainer to this repository and have them be the approver of commits.
  2. The community can fork this repo into another org that can be better maintained.
  3. Something else I couldn't think of...?

I think the first option is better as it avoids fragmentation of the community.

@cstroe

cstroe commented Nov 16, 2018

Copy link
Copy Markdown
Contributor Author

@gcberger @bvenners , I have signed and emailed the CLA.

@bvenners

Copy link
Copy Markdown
Contributor

@cstroe Thanks very much! I got the CLA. We'll get this merged and released as soon as we can.

@stefano-xy

Copy link
Copy Markdown

@bvenners , are the administrative problems solved? I would also like to have this merged. Thanks.

@manuzhang

Copy link
Copy Markdown

Any progress here ?

@bvenners

Copy link
Copy Markdown
Contributor

Sorry for the delay. I'll get it going.

@rondefreitas

Copy link
Copy Markdown

Thanks @bvenners . Looking forward to seeing this out there. There's a couple of other PRs I've been waiting on seeing merged (and I'm sure others). No pressure though and thanks for circling back to look at this project :)

@katrinsharp katrinsharp merged commit fe598ec into scalatest:master Aug 8, 2019
@manuzhang

Copy link
Copy Markdown

@bvenners @katrinsharp Thanks, is there a plan to make a new release with this fix ?

@cstroe cstroe deleted the use-correct-java branch August 9, 2019 14:22
@katrinsharp

Copy link
Copy Markdown
Collaborator

@manuzhang I'll discuss with @bvenners and let you know. Please stay tuned.

@manuzhang

Copy link
Copy Markdown

@katrinsharp @bvenners Thanks. Any plan to make a new release for this fix ?

@katrinsharp

Copy link
Copy Markdown
Collaborator

@manuzhang my bad I'm slow on some other open PRs to review. I'll try to fit all open ones in next couple of weeks.

@chetanmeh

Copy link
Copy Markdown

@katrinsharp Any plan to make a new release for this fix ?

@katrinsharp

Copy link
Copy Markdown
Collaborator

@chetanmeh My apologies! I'm going to handle this as we speak.

@chetanmeh

Copy link
Copy Markdown

Thanks @katrinsharp for responding and looking into this

@katrinsharp

Copy link
Copy Markdown
Collaborator

Update: I'm handling couple of different PRs and then release - several days.

@amirhadadi

Copy link
Copy Markdown

@katrinsharp can you please release a version with this fix?

@qsarahd

qsarahd commented Nov 3, 2020

Copy link
Copy Markdown

Joining the requests. @katrinsharp, can you please release a version with the fix?

@katrinsharp

katrinsharp commented Nov 4, 2020

Copy link
Copy Markdown
Collaborator

It was released. There is an issue to sync up with Maven central - I've put a request to get it sorted, meanwhile you can try the new version by adding this to your PM:

<pluginRepositories>
  <pluginRepository>
    <id>releases</id>
    <url>https://repo1.maven.org/maven2</url>
  </pluginRepository>
</pluginRepositories>

I'll add a new comment here letting everyone know that it was synced up with Maven central.

Update: you don't need to add thew above code, the jar did make its way into maven central, it is just https://mvnrepository.com/artifact/org.scalatest/scalatest-maven-plugin doesn't reflect that. I'm on it.

And it is on Maven central now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'java' is not recognized as an internal or external command